Tests not currently passing

Question

Tests not currently passing

Opened this issue 4 years ago · 5 comments

KyleMaas commented 4 years ago

Was trying to hunt down an issue and found that chloride's tests are not currently passing in the main branch.

Answer 1 · 2021-01-15T14:37:18.000Z

How so? This is the latest commit on main: https://github.com/ssb-js/chloride/runs/1611479946

Answer 2 · 2021-01-15T14:48:42.000Z

test-results-redacted.txt

Maybe I'm reading the output wrong, but I'm seeing a lot of "expected throw: Error: (something)" where in other tests it says PASSED. I would think the absence of PASSED and the presence of Error would indicate a problem. Here are the results I'm seeing, with working directory redacted.

Answer 3 · 2021-01-15T15:39:59.000Z

My memory: That's normal. This package doesn't use a normal test runner, see my comment in #22 .

Answer 4 · 2021-01-15T20:26:19.000Z

Hm. That's unfortunate. Not at all clear.

Answer 5 · 2021-01-15T20:30:11.000Z

Yep. It's fixed in #21 fwiw.