Error on process exit
alanshaw opened this issue · 7 comments
alanshaw commented
dgram.js:630
throw errnoException(err, 'dropMembership');
^
Error: dropMembership EINVAL
at _errnoException (util.js:1021:11)
at Socket.dropMembership (dgram.js:630:11)
at process.<anonymous> (/Users/alan/Code/tableflip/vers/node_modules/broadcast-stream/index.js:12:12)
at emitOne (events.js:115:13)
at process.emit (events.js:210:7)
at process.exit (internal/process.js:154:15)
at process.on (/Users/alan/Code/tableflip/vers/index.js:28:15)
at emitNone (events.js:105:13)
at process.emit (events.js:207:7)
at Signal.wrap.onsignal (internal/process.js:205:44)
dominictarr commented
hmm, maybe this is not needed anymore since reuseAddr is set? what do you think @clehner ?
clehner commented
Docs say:
This method is automatically called by the kernel when the socket is closed or the process terminates, so most apps will never have reason to call this.
So i don't think it is needed
mlegore commented
I can also repro this issue when killing a child process used by ssb-party
dominictarr commented
does actually cause problems or does it just output an error message?
mlegore commented
It opens an error dialog on process exit for me, which looks bad to the user.
dominictarr commented
I disabled dropMembership in 0.2.2, let me know it works
staltz commented
Seems to be unnecessary, indeed.