ssbc/go-ssb

Fix TestPeople (failing test)

Closed this issue · 2 comments

Following from #162

       people_test.go:265: 
            	Error Trace:	people_test.go:265
            	Error:      	Should be true
            	Test:       	TestPeople/negative_hops/badger
            	Messages:   	did not find peer alice in graph lookup table (len:0)
        people_test.go:265: 
            	Error Trace:	people_test.go:265
            	Error:      	Should be true
            	Test:       	TestPeople/negative_hops/badger
            	Messages:   	did not find peer bob in graph lookup table (len:0)
        builder_test.go:131: closed scenary

https://github.com/ssbc/go-ssb/actions/runs/3257660611/jobs/5349073080

Confusingly, different error when I run it locally:

--- FAIL: TestPeople (1.79s)
    --- FAIL: TestPeople/friends/badger (0.87s)
        people_test.go:62: created(8) alice as @Ex6Oyh9StHQ1+RWmM4H/HKxMxU8GzXajNFOpvUXNbNM=.ed25519 (algo:ed25519)
        people_test.go:62: created(9) bob as @MgrpJ/fxTYVENVcdQ8mkQNfWDaZ2uyCHF+cuHttqzQo=.ed25519 (algo:ed25519)
        people_test.go:62: created(10) claire as @0Iz7cEDYhIRo/eTF57m/h6jZpxpSwCyLewKTx3kzGSI=.ed25519 (algo:ed25519)
        people_test.go:274: 
            	Error Trace:	people_test.go:274
            	Error:      	Received unexpected error:
            	           	follows assert failed - wanted true
            	Test:       	TestPeople/friends/badger
            	Messages:   	assertion #1 failed
        people_test.go:274: 
            	Error Trace:	people_test.go:274
            	Error:      	Received unexpected error:
            	           	wrong hop count: [] +Inf
            	Test:       	TestPeople/friends/badger
            	Messages:   	assertion #4 failed
        people_test.go:274: 
            	Error Trace:	people_test.go:274
            	Error:      	Received unexpected error:
            	           	auth assert: alice didn't allow bob
            	Test:       	TestPeople/friends/badger
            	Messages:   	assertion #5 failed
        people_test.go:274: 
            	Error Trace:	people_test.go:274
            	Error:      	Received unexpected error:
            	           	auth assert: alice didn't allow claire
            	Test:       	TestPeople/friends/badger
            	Messages:   	assertion #8 failed
        builder_test.go:131: closed scenary

Running export LIBRARIAN_WRITEALL=0; go test -v ./graph -run TestPeople in isolation passes tho 🤔

This hard turned into a whole thing fixing other tests, so tracking via #167.