ssl/ezXSS

Add ability to block all subdomains by adding root domain to block list

geeknik opened this issue · 4 comments

Right now, adding example.com in v4.1 only blocks request from example.com, not a01.example.com or www.example.com. Adding example.com should block *.example.com unless one or more of the subdomains is in the whitelist.

I'd argue that it makes more sense to block example.com and *.example.com as separate entries rather then including all subdomains when blocking the parent domain and vice versa.

Well, wildcard matching was added in 3.1, but didn't make it into 4.1 for some reason. When I try to add *.example.*, nothing is added.

ssl commented

Hey @geeknik,

I was about to say, I believe it is already possible to add *.example.com.

I will look into this. It might broke without me noticiing in some release.

ssl commented

Seems that only the input was not working correctly, thinking '*' can not be a valid character in a domain. Fixed it in 796222c