v0.11.0 release checklist

Question

v0.11.0 release checklist

ssube opened this issue a year ago · 8 comments

Answer 1 · 2023-12-03T21:32:01.000Z

The first RC for v0.11 has been built from commit 0b31ad0:

Windows bundle: https://pub-3c28d2c7c34e41c6a9189ffe0abd7d0b.r2.dev/onnx-web-v0.11.0-rc-0b31ad0a.zip

Answer 2 · 2023-12-03T21:38:18.000Z

Release tests are currently passing with --mse 10.0, which should be reduced before release.

New tests need to be added to the test plan for SDXL and LCM.

Answer 3 · 2023-12-17T20:56:01.000Z

New release tests have been added, along with a getting started guide for new users. Most new features have been documented except for some parameters in the user guide.

Release tests are still passing at mse 10.0, although that can be reduced if you skip non-deterministic schedulers.

Answer 4 · 2023-12-20T20:57:23.000Z

manual interactions QA (using Windows 10 + AMD card, in Chrome)

generating a new image
- requests and then loads a new image from the server
canceling a pending image
- removes the pending image and leaves the resst
deleting a finished image
- removes the deleted image and leaves the rest
copying a finished image to img2img
- switches to the img2img tab
- populates the image source with the correct image
- the generate button is enabled

copy an image to inpaint

switches to the inpaint tab, but then the page crashes
related console error:
this does not happen when copying the image to inpaint while already on the inpaint tab

main.js:36221 Uncaught Error: value not found
  at mustExist (main.js:36221:13)
  at getContext (main.js:76838:20)
  at getClearContext (main.js:76844:17)
  at MaskCanvas (main.js:76755:9)
  at renderWithHooks (main.js:14786:28)
  at mountIndeterminateComponent (main.js:17642:23)
  at beginWork (main.js:18658:24)
  at HTMLUnknownElement.callCallback (main.js:5821:24)
  at Object.invokeGuardedCallbackDev (main.js:5848:26)
  at invokeGuardedCallback (main.js:5882:41)

copy an image to upscale

switches to the upscale tab, but then the page crashes
the upscale tab in general crashes when manually navigating to it
related console error (happens in both instances)

Uncaught TypeError: Cannot read properties of undefined (reading 'matchAll')
  at extractNetworks (main.js:82363:33)
  at main.js:82277:24
  at mountMemo (main.js:15472:29)
  at Object.useMemo (main.js:15815:26)
  at useMemo (main.js:1179:31)
  at PromptTextBlock (main.js:82276:20)
  at renderWithHooks (main.js:14786:28)
  at mountIndeterminateComponent (main.js:17642:23)
  at beginWork (main.js:18658:24)
  at HTMLUnknownElement.callCallback (main.js:5821:24)

copy two images to blend

switches to the blend tab, but then the page crashes
this does not happen when copying the images to blend while already on the blend tab
related console error:

Uncaught Error: value not found
  at mustExist (main.js:36221:13)
  at getContext (main.js:76838:20)
  at getClearContext (main.js:76844:17)
  at MaskCanvas (main.js:76755:9)
  at renderWithHooks (main.js:14786:28)
  at mountIndeterminateComponent (main.js:17642:23)
  at beginWork (main.js:18658:24)
  at beginWork$1 (main.js:22635:24)
  at performUnitOfWork (main.js:22061:23)
  at workLoopSync (main.js:21994:15)

states after refresh:
- loading images persist
- tab location persists
- image sources do not persist

Answer 5 · 2023-12-21T03:14:38.000Z

Thank you for helping with the UI testing. I was able to reproduce 2 of those 3 bugs, but I was not able to find the crash on the upscale tab. I know where that is in the code and put some defensive checks in place, but I wasn't able to reproduce it, so I'm not able to verify that it is fixed. The MaskCanvas crash was easy to reproduce, so I'm pretty sure I was able to fix that one.

Answer 6 · 2023-12-22T20:40:18.000Z

Most of the release tests have passed, but there are two remaining errors that I'm aware of:

converting upscaling models using the Windows bundle fails with a deprecated import error
running the SD v2.1 release tests against the Windows bundle fails with a tensor shape error while parsing the prompt

The first one will block the release until I can fix it, but the second might be related to the lack of negative prompt in the test data, and SD v2.1 is not enabled/converted by default.

I have gone through some of Civitai's most popular models and checked the licenses, and it looks like most of them allow redistribution under the same terms, so I will be preparing pre-converted archives for them. I may replace the Windows bundle's extras file with one that downloads the pre-converted archives to make things faster/easier for new users.

Answer 7 · 2023-12-23T03:04:03.000Z

Both of the remaining errors have been resolved:

the conversion error was fixed with a monkeypatch in basicsr to use the newer import
the SD v2.1 and inpainting/outpainting test errors were caused by badly converted models, converted again resolved them

The latest RC bundle is https://pub-3c28d2c7c34e41c6a9189ffe0abd7d0b.r2.dev/onnx-web-v0.11.0-rc-3d245a66.zip.

Answer 8 · 2023-12-24T20:49:45.000Z

Most of the conversion bugs have been squashed, although #446 is still lingering for a few models (Cetus, Faetastic, maybe others). So far, using the "pipeline": "txt2img-legacy" flag seems to be working, and the release bundle comes with pre-converted models anyways.