st-h/ember-content-editable

Add peerDependency `ember-source v5`

mkszepp opened this issue · 6 comments

Atm ember-content-editable has as dependency "ember-source": "^4.0.0"

"peerDependencies": {
"ember-source": "^4.0.0"
},

It would be greate to add ember-source v5, otherwise there is not possible to use this addon with ember v5

"peerDependencies": {
    "ember-source": "^4.0.0 || >= 5.0.0"
  },

If you need any help, just tell me, so i will add a PR

st-h commented

Thanks for raising this. Could you please try version 4.0.0-rc.2, which has ember 5 as a peer dependency. Would probably be better to allow ember 4 and 5 as shown in your snippet, though.

@st-h thanks! we will try it, when we have all other packages ready for ember v5, because we have some packages which are atm not ready for ember v5.
It would be great to allow v4 also for ember v4, so we can already us it.

st-h commented

Sure. Could you please give 4.0.0-rc.6 a try, which has the modified peer dependency?

@st-h it looks good ❤️. i have updated the package and it works. Thank you