stack-auth/stack

Handler component should expand to the size of the viewport

career-tokens opened this issue · 5 comments

N2D4 commented

@fomalhautb Thoughts on how to best fix this?

fomalhautb commented

You need to set the min-height of the outer div and the fullPage=true for the SignIn component, then the component will automatically grow to the outer div size. I can't make it automatically grow to full-screen hight/width because then if you have a header or sidebar, the page will overflow. Let me know if that fixes the issue. You can check out the layout page in demo as an example.

N2D4 commented

We can definitely have some better defaults for cases like these though, let's keep this open for now. The handler isn't usually wrapped in a user-written component besides the layout.tsx itself

Here are some things that we can consider, maybe a mix of these can work for most situations:

  • 100vh
  • 100vh - el.offset().top
  • align-self: stretch
  • flex-grow: 1
  • position: absolute; left: 50%; top: 50%; transform: translate(-50%, -50%)
  • ...?
career-tokens commented

um I mean there are some default redirects and customising them is difficult like when you reset the password and want to come back to the login page, the default reset page appears and its UI is not good
Wouldnt it be better if the default is full page and if the user wants it then they can change the size?

N2D4 commented

Should be fixed with the next release!