stacktracejs/stackframe

toString does not match V8 stack trace format

niftylettuce opened this issue 6 years ago · 2 comments

niftylettuce commented 6 years ago

Could we modify toString so that it closely matches https://v8.dev/docs/stack-trace-api#appendix%3A-stack-trace-format instead of current format?

Calling Error.prepareStackTrace(err, stackframes) does not give proper output.

niftylettuce commented 6 years ago

Here is how Node prepares it:

https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

eriwen commented 6 years ago

This is fixed by #23. Thanks @niftylettuce!