stakater/GitWebhookProxy

Possibility to whitelist webhooks ip addresses

azkore opened this issue · 3 comments

azkore commented

In the case of GitHub, would it be possible to add an option to query GitHub api for IP ranges used by webhooks and only allow access from them? It seems like the most secure option.

Don't know what's the situation with GitLab, but maybe they have similar API.

antonpiatek-imanage commented

You could always achieve this with your own firewall rules

  • 👍1
davidkarlsen commented

also if you expose the webhook with ngrok or similar they have a whitelist option.

  • 👍1
rasheedamir commented

yes and we suggest to add firewall rules in the ingress controller

I don't think we should add this feature in GWP! it can be handled at one level above

  • 👍1