eslint plugins should be peer dependencies
timlesallen opened this issue · 3 comments
For example, I get this when I've installed semistandard into my project and am calling it in package.json:
Error: Failed to load plugin react: Cannot find module 'eslint-plugin-react'
This is because it is getting installed in the node_modules of semistandard and therefore, eslint cannot find it.
The correct way to do this would be to specify the eslint plugins as peer depencies, not as normal dependencies.
I'd be happy to make a PR for this...
@Flet If I made a PR for this issue would you merge it? :)
The "workaround" I found is install all of semistandard's dependencies as dev dependencies in the project or on a CI job cd into the node_modules/semistandard and run npm i
Hey sorry for leaving you hanging on this. I'm going to close this issue because I don't believe this is an problem with modern versions of node/npm. Feel free to reply if this is still a problem!