stanford-crfm/helm

Fix issue with clicking first col in leaderboards

farzaank opened this issue · 5 comments

farzaank commented

doesnt take you to the right groups

farzaank commented

This issue seems to be resolved, may have been due to an outdated front-end.

Edit: not true, this behavior happens when you use the dropdown to navigate between scenarios but not if you visit directly via the scenario page. My PR decoupling these two will make it so that this issue is more egregious.

yifanmai commented

Not resolved, but only affects certain tables.

For instance, for the LegalBench group on https://crfm.stanford.edu/helm/lite/v1.5.0/#/leaderboard

  • In the first tab:
    • The first column is not clickable (incorrect behavior)
    • The second column is clickable and goes to the all LegalBench runs for the model (correct behavior)
  • In the second tab:
    • The first column is clickable and goes to a single LegalBench run for the model (correct behavior)
    • The second column is clickable and goes to all the runs for the model, not just LegalBench (incorrect behavior)
yifanmai commented

Also note that the change needs to be made to helm-summarize, not the React frontend.

farzaank commented

Yes that's right. I found that out shortly after closing, but opted not to re-open as there is a duplicate issue (#2434) which I commented on and left open afterwards.

I should have left a comment here as well.

Now, I'll close the other as a duplicate since you added more details here.

yifanmai commented

Great, thanks!