Pylint alerts corrections as part of intervention experiment
evidencebp opened this issue · 9 comments
I'd like to conduct a software engineering experiment regarding the benefit of Pylint alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.
I'm asking your approval for conducting the interventions in your repositories.The interventions are expected to benefit the project and will submitted in PR for approval.
These are the planed interventions.
Sorry, we adopt black for arranging and formatting Python code under knowledge_storm. We cannot adopt your interventions as it will break the current contribution pipeline. I am sorry for this.
Thank you for your response.
The alerts that I'm interested in are not related to style.
For example, there are alerts on too many branches in a function and catching a too broad exception.
@shaoyijia , will it be ok to do the contributions while also following the black formatting?
Could you restrict the modification to exclude files under knowledge_storm? I do hope to support your research, but files under knowledge_storm is linked to our python package and production demo. I don't have bandwidth to review all those critical changes.
Could you restrict the modification to exclude files under
knowledge_storm? I do hope to support your research, but files underknowledge_stormis linked to our python package and production demo. I don't have bandwidth to review all those critical changes.
Sure, I will.
Thanks!
Sounds great. You could add more description to the PR once you have it and mark me as reviewer.
Sure.
I removed the knowledge_strome files from the planed interventions.
@shaoyijia , please note the PR
Thanks!
Yucheng helps review this PR. Could you check out his comment?
Sure, I answered in the PR.
Thank you both for your help!