User not informed of faults in interserver syntax.
Closed this issue · 0 comments
Pheotis commented
Bug Description
Making an invalid interserver portal fails without informing the user of the reason.
Reproduction Steps
Make an invalid interserver portal. Check the logs at FINER or greater.
Desired Behaviour
This should fail, with some sort of fault message being sent to the user.
Observed Behaviour
Fails with no fault message.
org.sgrewritten.stargate.exception.name.NameLengthException: Invalid length of name 'IntServerBork' , name length must be above 0 and under 13
at Stargate-1.0.0.16-NIGHTLY-3.jar//org.sgrewritten.stargate.network.portal.StargatePortal.<init>(StargatePortal.java:116)
at Stargate-1.0.0.16-NIGHTLY-3.jar//org.sgrewritten.stargate.util.portal.PortalCreationHelper.createPortal(PortalCreationHelper.java:67)
at Stargate-1.0.0.16-NIGHTLY-3.jar//org.sgrewritten.stargate.api.network.PortalBuilder.build(PortalBuilder.java:295)
at Stargate-1.0.0.16-NIGHTLY-3.jar//org.sgrewritten.stargate.listener.BlockEventListener.onSignChange(BlockEventListener.java:194)
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor41.execute(Unknown Source)
at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:627)
at net.minecraft.world.level.block.entity.SignBlockEntity.setMessages(SignBlockEntity.java:226)
at net.minecraft.world.level.block.entity.SignBlockEntity.lambda$updateSignText$4(SignBlockEntity.java:187)
at net.minecraft.world.level.block.entity.SignBlockEntity.updateText(SignBlockEntity.java:201)
at net.minecraft.world.level.block.entity.SignBlockEntity.updateSignText(SignBlockEntity.java:186)
at net.minecraft.server.network.ServerGamePacketListenerImpl.updateSignText(ServerGamePacketListenerImpl.java:3457)
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleSignUpdate$20(ServerGamePacketListenerImpl.java:3438)
at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718)
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
at net.minecraft.server.TickTask.run(TickTask.java:18)
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151)
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1511)
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:195)
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125)
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1488)
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1411)
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135)
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1377)
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1238)
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323)
at java.base/java.lang.Thread.run(Thread.java:1583)
Trace Logs
Latest version of all modules with latest core on latest paper.
Other Information
Possibly related to #352