[Bug Report] Broken lightbox display modes
cj12312021 opened this issue · 1 comments
Describe the bug
Since #4569 was merged, the Lightbox no longer scales images appropriately to fit the screen (see: https://discordapp.com/channels/559159668438728723/644934273459290145/1213285460290314370). The full-screen button, as well as the different display modes, are also broken as a result of the change. Adding the max-height: 90vh; property will at least force the image to fit the screen and force the fit-to-screen option. However, this does not work for the other display modes. I don't use image clips, so it's unclear how or if those modes work with clips after that change, but I find it hard to believe they are.
As I've been looking into this more, I see the issues I described in the original comment are only present when the lightbox is used to view images outside of the images page, so movie covers, performer images, or scrubber images. My hunch is that this is due to #4569 assuming all images used by the lightbox have weight and height property set. I suspect that is not the case for nonofficial images.