stashapp/stash

[Bug Report] Image Wall Margin is set to 2px but displays 0px.

Closed this issue · 10 comments

Describe the bug
Image Wall Margin setting is set to 2px, but the image wall displays 0px between each image. To fix, I have to go into the settings, erase the "2", add a "02", then confirm. On relauch it will reset itself back to falsely saying it's at 2px but actually be at 0px.
Trying to set it to "2" or "02" within the config.yml file does not fix it.

To Reproduce
Steps to reproduce the behavior:
0. Nothing to exactly reproduce, it happens on launch. The only fix I know gets reset on relaunch.

  1. Go to Interface Settings.
  2. Click on Edit [Image Wall Margin]
  3. "2" is displayed. Backspace so the "0" appears.
  4. Add a "2" alongside the "0".
  5. Fixed
  6. Broken on Quit.

Expected behavior
Launching the exe should remember my settings.

Screenshots

0
1
2
3
4

Stash Version: v0.27.2

Desktop (please complete the following information):

  • OS: Windows 11 version 23H2
  • Browser: Edge
  • Version: 131.0.2903.51 (Official build)
Gykes commented

Unable to replicate this on Dev version on docker.

Do you have any themes or plugins that could be messing with those settings?

I have neither of those enabled. Just in case, JavaScript status does not matter either.

Gykes commented

Hmm, even on my V27.2 (Still docker) I can't reproduce. Not sure why that's happening. Have you tried a different browser?

Same results on Firefox when I restart Stash.

Gykes commented

Okay, perhaps someone with a windows StashServer can help try and replicate. Until I find a way to track it down I can't help, sorry :(

Can't replicate on windows v0.27.2

If you have any plugins or custom css, disable it.

I do not have those enabled.

Then I'm not sure what is interfering with stash. the 02 should auto-correct into just 2 in the UI

Managed to reproduce this. It's occurring because the stash server is saving the UI config numeric fields as strings, and these aren't being converted correctly in the UI. The Gallery control is erroring because it is being provided a string instead of a number, and sets the margin to 0. This gets fixed by setting the value in the UI because it sets the numeric value in the browser, but when it reloads the config again, the correct value is lost.