stateful/runme

Internal failure executing runner: failed program lookup "deno run"

sourishkrout opened this issue · 4 comments

Instead of looking up deno run it should attempt a look up against deno and prepend run to the args stack.

https://github.com/stateful/runme/blob/main/internal/command/command.go#L102-L116

This works in runner v1. Let's be sure to add a test case.

Good point! It was done in the following way in runnerv1:

func parseFileProgram(programPath string) (program string, args []string) {
parts := strings.SplitN(programPath, " ", 2)
if len(parts) > 0 {
program = parts[0]
}
if len(parts) > 1 {
args = []string{parts[1]}
}
return
}

Good point! It was done in the following way in runnerv1:

That works but also open to alternatives if you have something else in mind 👍.

@sourishkrout to confirm the use case, does deno run come from the client in runme.runner.v2alpha1.ProgramConfig.program_name?

@sourishkrout to confirm the use case, does deno run come from the client in runme.runner.v2alpha1.ProgramConfig.program_name?

Just saw this now... Yes, I believe that's what's being set plus the CommandMode=File.