Does byteutils need to import assign2 since arrayops imports and exports assign2?

Question

Does byteutils need to import assign2 since arrayops imports and exports assign2?

Closed this issue 3 years ago · 3 comments

I frequently see:

.../stew/byteutils.nim(15, 3) Warning: imported and not used: 'assign2' [UnusedImport]

in compiler output. I know it's no big deal, but if the import isn't needed in byteutils then perhaps it can be removed to eliminate the warning?

Answer 1 · 2022-01-05T18:45:46.000Z

If tests compile without, it's not needed

Answer 2 · 2022-01-05T21:23:47.000Z

Tests pass, cf. #100.

Answer 3 · 2022-01-06T07:32:00.000Z

as a general tip, if you want to know if something is needed or not in the grander scheme of things, the best stress test we have is to clone nimbus-eth2 and compile with your change enabled there - if nimbus-eth2 compiles, so will everything else, most likely. cleanup patches like this are most welcome.