stav/wgrep

Only installs with up to Node v8

Closed this issue · 7 comments

almereyda commented

Installing this with Node v14, v12 and v10 will lead to a node-gyp rebuild error on installation.

Latest known version to work is Node v8.

stav commented

Thanks for reporting.

Would you be willing to paste your terminal output if you're still getting the error.

stav commented

Seems to work fine for me.

My tests have been using node version 12 for a couple years.

Version 10:

$ nvm install 10 --lts
Downloading and installing node v10.24.1...
Downloading https://nodejs.org/dist/v10.24.1/node-v10.24.1-linux-x64.tar.xz...
Now using node v10.24.1 (npm v6.14.12)

$ node -v
v10.24.1

$ npm i -g
+ wgrep@0.4.6
added 64 packages from 44 contributors in 6.743s

$ wgrep stav https://github.com/stav/wgrepCalling for "stav" in "output" from "https://github.com/stav/wgrep" with user "undefined"
Looking in "output" for 'stav'
Found 3 files
[ 'output/stav/wgrep/code_menu_contents/master/index.html',
  'output/stav/wgrep/index.html',
  'output/stav/wgrep/overview_actions/master/index.html' ]

Version 12:

$ nvm install 12 --lts
Downloading and installing node v12.22.6...
Downloading https://nodejs.org/dist/v12.22.6/node-v12.22.6-linux-x64.tar.xz...
Now using node v12.22.6 (npm v6.14.15)

$ node -v
v12.22.6

# npm i -g
+ wgrep@0.4.6
added 1 package from 1 contributor in 0.219s

$ wgrep stav https://github.com/stav/wgrep
Calling for "stav" in "output" from "https://github.com/stav/wgrep" with user "undefined"
Looking in "output" for 'stav'
Found 3 files
[
  'output/stav/wgrep/code_menu_contents/master/index.html',
  'output/stav/wgrep/index.html',
  'output/stav/wgrep/overview_actions/master/index.html'
]

Version 14:

$nvm install 14 --lts
Downloading and installing node v14.18.0...
Downloading https://nodejs.org/dist/v14.18.0/node-v14.18.0-linux-x64.tar.xz...
Now using node v14.18.0 (npm v6.14.15)

$ node -v
v14.18.0

$ npm i -g
+ wgrep@0.4.6
added 1 package from 1 contributor in 0.239s

$ wgrep stav https://github.com/stav/wgrep
Calling for "stav" in "output" from "https://github.com/stav/wgrep" with user "undefined"
Looking in "output" for 'stav'
Found 3 files
[
  'output/stav/wgrep/code_menu_contents/master/index.html',
  'output/stav/wgrep/index.html',
  'output/stav/wgrep/overview_actions/master/index.html'
]

Version 16:

$ nvm install 16 --lts
Downloading and installing node v16.11.0...
Downloading https://nodejs.org/dist/v16.11.0/node-v16.11.0-linux-x64.tar.xz...
Now using node v16.11.0 (npm v8.0.0)

$ node -v
v16.11.0

$ npm i -g
added 1 package, and audited 3 packages in 649ms
found 0 vulnerabilities

$ wgrep stav https://github.com/stav/wgrep
Calling for "stav" in "output" from "https://github.com/stav/wgrep" with user "undefined"
Looking in "output" for 'stav'
Found 3 files
[
  'output/stav/wgrep/code_menu_contents/master/index.html',
  'output/stav/wgrep/index.html',
  'output/stav/wgrep/overview_actions/master/index.html'
]
arkarkark commented

I get gyp build errors with node v17.8.0 (from brew)
when using both npm or yarn

npm install -g wgrep > /tmp/wgrepinstall.txt 2>&1 gives me this file
wgrepinstall.txt

stav commented

Thanks for reporting @arkarkark.

Contextify is not in the lockfile so why is your build trying to install it? Did your lockfile get changed? Are you somehow using an old version of JSDOM?

arkarkark commented

It's been ages since I used node, but I think it's trying to build it because gyp wants it?
and since I'm installing from npm I think it's using this which is 7 years old?

stav commented

Ah ok, right thanks for that.

I didn't realize that wgrep was already a Node.js package which was not the best naming choice on my part, since the name wgrep is already taken.

So yeah, looks like you tried to do:

npm install wgrep

instead of:

git clone https://github.com/stav/wgrep.git
cd wgrep
npm install -g
arkarkark commented

or.... I'm reporting this issue in the wrong repo! so sorry about that.
You'll be glad to hear, your repo as much better seo though,

  • 😄2