stdlib-js/stdlib

[RFC]: add `math/base/special/asinhf`

gunjjoshi opened this issue ยท 5 comments

Description

This RFC proposes adding math/base/special/asinhf, which would be the single-precision equivalent for math/base/special/asinh.

float stdlib_base_asinhf( const float x )

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.

I would like to work on this.

This requires log1pf, which must be implemented first. Our log1p is based on https://www.netlib.org/fdlibm/s_log1p.c, but I couldn't find the single-precision implementation for it. Is it there ? If not, what source must we then follow for log1pf ?

Use FreeBSD v12.2.0. Our log1p probably needs to be updated, as I imagine that the fdlibm implementation is somewhat out-of-date.

log1pf, in turn, requires roundf. It isn't needed for the function's implementation, but is required at examples/index.js.
Should I go ahead for roundf ?