stefanuebe/vaadin-fullcalendar

Text set to lumo-disabled-text-color by default

JaakkoHintsala opened this issue · 8 comments

Vaadin version 23.3.28
vaadin-fullcalendar version 6.2.0

text color is set to lumo-disabled-text-color by default
kuva

I suppose it is caused by this
#157 (comment)

I was able to fix this with some css:
.fc.fix-text-color a:not(:any-link){ color: var(--lumo-body-text-color); }
and then
calendar.addClassName("fix-text-color");

Strange, this should be fixed already. I'll check that

The full-calendar-styles.css contains this styles, that addresses the mentioned issue.

.vaadin-full-calendar.fc {
    /*display: block;*/ /*not sure why this was here, keeping it for now, but breaks the normal displayment*/

    /* Fixes a color issue, where otherwise day numbers would appear as the disabled text color (Idk why)*/
    a:not(:any-link) {
        color: var(--lumo-body-text-color);
    }
    ...
}

And at least the demo with V24 shows the stylings correctly

image

So maybe V23 has a problem with nested css. I also had issues with nested css in a customer project, where they used older browser versions.

Can you please check, if the demo works for you or if it also shows grayed out day numbers? https://stefan.app.fi/fullcalendar-demo/

So maybe V23 has a problem with nested css. I also had issues with nested css in a customer project, where they used older browser versions.

Can you please check, if the demo works for you or if it also shows grayed out day numbers? https://stefan.app.fi/fullcalendar-demo/

The demo works with my browser (Firefox 115.7.0esr)
turns out the CSS exists but it is garbled out for some reason on the problem calendar.
kuva
The error says "Invalid property name"

It was related to the browser after all. When I opened the exact same calendar on chromium the CSS works.
kuva

Yeah, this "scrambled" css is also shown for me in Chrome. It works nevertheless, so no idea, why Chrome has issues showing nested css in its browser tools.

But to allow usage of older browsers, I will revert the styling from nested to old school, full blown selectors with the next bugfix release.

Release 6.2.1. Stylesheets should now be shown clean and work in older browser versions.

Thank you for the fix!