Entrypoint does not allow overwrite

Line 21 in 99f694c

ENTRYPOINT ["icloud-photos-sync", "daemon"]

This will now always run in daemon mode. I am trying to run it on synology and there is only a way to specify the command, which is now impossible.

This is the same behaviour as previously? What do you try to achieve, which is no longer possible.

I'm not too familiar with Synology's Docker implementation, however it is possible to overwrite the entrypoint of a docker container, see for example this guide

Previously the ENTRYPOINT did not contain any commands:

icloud-photos-sync/docker/Dockerfile

Line 21 in 80c0620

ENTRYPOINT ["icloud-photos-sync"]

Best practice is to separate the command from the entry point, like so:
ENTRYPOINT ["icloud-photos-sync"]
CMD ["daemon"]

The command can then be easily overwritten from the CLI (or in my case Synology). Where as now it will only ever run in daemon mode.

Thanks for considering!

That makes sense! I completely forgot about CMD - fixed in 444fa33

Thank you!