`process_pending_deposits` uses Unix-specific python standard library functions
Closed this issue · 5 comments
Polaris uses the loop.add_signal_handler() function, which is a unix-specific function since Windows does not have signals.
Running process_pending_deposits on a windows machine will result in an immediate crash of the program with a NotImplementedError.
We need to refactor the graceful cleanup logic to use os-agnostic functionality. cc @stfung77
Thanks for taking it up @stfung77
@Unique-coder would you mind testing the change in this PR (#615)? None of us have a windows setup handy to test this out.
Alright @stfung77. I will test it out, and get back to you
Hey @Unique-coder, did you get a change to test this out? we're trying to release in the next day or two so let us know if you don't have the bandwidth to test this. thanks!