step-security/secure-repo

Harden GitHub Actions Workflow - code-review.yml

Closed this issue · 0 comments

GitHub Token Permissions Are Not Set to Minimum in Workflow

Summary

The GitHub token permissions in your workflow file (.github/workflows/code-review.yml) exceed the minimum required. Reducing permissions to the minimum necessary enhances security by limiting the access scope of the token, thereby lowering the risk of accidental or malicious misuse.

Why This is Important

Using excessive permissions in GitHub workflows can expose your repository to potential security risks. The GitHub token grants access to repository resources, and any unnecessary permissions increase the likelihood of sensitive actions being performed without justification. By applying the principle of least privilege, you protect your repository from unintended data exposure and ensure that each job only has access to what it absolutely needs.

Evidence of Excessive Permissions

For more context, please refer to the build log from your recent workflow run, which highlights the permissions granted to the GitHub token that exceed the recommended minimum.

Suggested Fix

Below is the updated permissions configuration, which minimizes access for the GitHub token. Update your workflow file with this suggested configuration to resolve this issue:

```diff
  name: Code Review
  on:
    pull_request:
  permissions:
    contents: read
  jobs:
    code-review:
      runs-on: ubuntu-latest
      permissions:
        contents: read
        pull-requests: read
      steps:
        - name: Harden Runner
          uses: step-security/harden-runner@17d0e2bd7d51742c71671bd19fa12bdc9d40a3d6 # v2.8.1
          with:
            disable-sudo: true
            egress-policy: block
            allowed-endpoints: >
              api.github.com:443
              int.api.stepsecurity.io:443
        - name: Code Review
          uses: step-security/ai-codewise@int

Next Steps

Please review and update the workflow file with these minimum permissions. If additional permissions are necessary for certain steps, specify only those permissions explicitly.

For further guidance, refer to the GitHub documentation on fine-grained permissions.

Severity: High