stephenafamo/bob

[psql] Issues with window functions

Closed this issue · 0 comments

relvacode commented

The window argument to Function.Over is unused.
https://github.com/stephenafamo/bob/blob/main/dialect/psql/dialect/function.go#L76

Additionally, OVER () with an empty window definition is a valid statement, at least for PostgreSQL but is currently not possible due to wr.def.Valid()
https://github.com/stephenafamo/bob/blob/main/dialect/psql/dialect/function.go#L122