stephenplusplus/grunt-wiredep

Line Endings on Windows

coreyog opened this issue · 3 comments

On a windows machine you end up injecting using \n instead of \r\n.

When joining this plugin with other plugins, this can cause major breaking issues.

For example, I'm using yeoman to concatenate, minify, and version my javascript files, including my bower js files. Yeoman knows I'm on windows and looks for \r\n but currently this plugin breaks that using only \n.

The problem can be traced to inject-dependencies.js:89

There is no inject-dependencies.js in this repo. I think you meant to post this on taptapship/wiredep (the module that this plugin uses).

But going over there, there's nothing about line endings on inject-dependencies.js:89. When referring to source code, please use the permanent link to the file as what's on master is constantly changing.

For now tho, please close this ticket and reopen on taptapship/wiredep

So sorry. The bug is related to an older version (0.7.0) in my frustration of hunting down what went wrong, I overlooked that.

No worries! Thanks for taking the time to report a bug and try to help. If you're still having issues on the latest, let us know (and if the issue is with wiredep itself, that other repo is the best place to post those!).