stephpy/timeline-bundle

3bd3134 has a BC break

Closed this issue · 6 comments

after upgrading to 3bd3134 we're getting

The service "highco.timeline.spread.deployer" has a dependency on a non-existent service "highco.timeline.provider".

Do we need to upgrade anything in our setup?

azr commented

Yup same here, I added

    provider:
        service: highco.timeline.provider.doctrine.orm
        object_manager: doctrine.orm.entity_manager
        timeline_class: NS\Bundle\Entity\Timeline

Now getting :

The service definition "highco.timeline.provider.doctrine.orm" does not exist.

azr commented

Reading the code I could manage to make it work setting :

    provider:
        object_manager: doctrine.orm.entity_manager
#        service: highco.timeline.provider.doctrine.orm
        type: orm
        timeline_class: NS\Bundle\Entity\Timeline

Cool I can use orm now :D

any idea how to do this for the redis provider?

azr commented

may be with type: redis ?

Yep, type:redis should fix this issue, i'll update code to be BC and use redis provider by default. Thanks for this catch.

A validation has been added on e58c449. By cons, It's still BC break

Sorry for inconvenience