BC Break?

Question

BC Break?

Closed this issue 12 years ago · 7 comments

Did the last updates cause a BC break? I am suddenly getting an error:

Invalid argument supplied for foreach() in /ffo/bar/vendor/stephpy/timeline/src/Spy/Timeline/Model/Action.php line 311

Thanks!

Answer 1 · 2012-12-19T15:05:15.000Z

Hi,

It should not, update the timeline repository, i use getter instead of property, if it fixes the issue, i guess it's due to a overload of $actionComponents property (defined as private) on your class

Answer 2 · 2012-12-19T15:09:05.000Z

If the issue stays, it seems your $actionComponents property is not an array, it MUST be an array. Have you followed step 3 of documentation ?

Use protected and not private on properties.

I hope it fixes your issue, sorry for inconvenience.

Answer 3 · 2012-12-19T15:17:24.000Z

Nope didn't work.. Everything seems to work in a an update I pushed this morning. So somewhere between now and then it went wrong.

Ans is an array:

$action = $actionManager->create($update->getAuthor(), 'updated_status',  array('directComplement' => $update));

Any clues?

Answer 4 · 2012-12-19T15:18:46.000Z

I investigate, wait a minute.

Answer 5 · 2012-12-19T15:21:10.000Z

i got the same issue -____- it seems to be a stupide mistake, one sec.

Answer 6 · 2012-12-19T15:37:24.000Z

It seems with array there is some issues with pagers, let come back wich protected $actionComponents, i intialized on constructors collection.

Answer 7 · 2012-12-19T15:39:20.000Z

It should be OK now, reopen if you have any issue.

Sorry for this stupid issue.