stevejenkins/postwhite

remove and simplify equally time consuming

RobertChalmers opened this issue · 3 comments

# Do this to invalid IPv4 addresses and CIDRs (remove / fix / keep)
invalidip4=remove

# Simplify (remove) IP addresses from the whitelist that are already covered by CIDRs
# WARNING: Enabling this option can dramatically increase the time Postwhite takes to
# run if you have many mailers selected. Try it once, then come back and turn it off. :)
simplify=no

This is taken directly from 1.17, and so far it's been removing invalid IPv4 CIDRs for about 20 minutes so far with no end in sight ...

So it would be well to add the same WARNING to the "invalidPv4" section as applies to 'simplify' - given the time and processing it takes.

I don't think it's just time consuming... I think it's stuck in some sort of infinite loop!

I'm now on my OSX laptop, and have reproduced the hang. Testing to see what's causing it now.

Got it. It's the backgrounding of the processes I used to allow the pretty show_dots to work.

OSX should be able to background processes!

I'll see if there's a way to keep that feature and still run on OSX. If not, I'll just remove it and everyone will just have to live without the dots. :)

The problem wasn't the normalize process, it was actually the show_dots :)

Changed the code so it doesn't loop on OSX. @ShanghaiTimes: Please try v1.18 to confirm that it's also working on your system.