stevensona/shader-toy

[BUG] iUniform parse error

Closed this issue · 3 comments

jcyuan commented

2 problems:

1, if you write some vec4 iUniform type, it makes your shader stops from working, see the GUI panel, it has only the first uniform, and even there is no error at all! :
image

and if you remove all the vec4 (in the red rectangle of the pic) or change them to const, other parameters appears again.
image

2, you can't write float number as ".2" for 0.2 for the iUniform type, it will brings error:
image

cool tool, thanks so much.

jcyuan commented

ah right, iUniform float abc = -0.5 error.

Malacath-92 commented

Thanks for bringing up the bugs. But generally, please create separate issues for reporting multiple bugs.
Since this feature requires us to parse parts of the code ourselves it's very possible we just didn't cover all cases. So I'll check to parse floating point numbers correctly, covering all corner cases.
The issue with vec4 is less obvious, I'll see what I can do.
I'm happy to get issues reported for uniforms, since those are still somewhat experimental.

jcyuan commented

@Malacath-92 ok sorry. next time will seperate each issues.