stm32-rs/stm32wlxx-hal

Nitpicks

newAM opened this issue · 0 comments

newAM commented
  • Replace wall-of-text # Safety sections with enumerated check-lists of requirements.
  • Lots of duplicated code across testsuites (fixed in #82)
  • Provide a from_millis, from_nanos, from_secs ect. with subghz::Timeout
  • Normalize meta-access of peripherals for all peripherals (maybe trait these to enforce uniformity?)
    • pub unsafe fn steal() -> Self
    • fn mask_irq()
    • pub unsafe fn unmask_irq()
    • pub unsafe fn pulse_reset(rcc: &mut pac::RCC)
    • pub fn enable_clock(rcc: &mut pac::RCC)
    • pub unsafe fn disable_clock(rcc: &mut pac::RCC)
    • Normalize what new does with regards to clocks, resets, enables, and interrupts