stocnet/goldfish

opportunitiesList seems not to be considered for model estimation

Closed this issue · 3 comments

hnunner commented

opportunitiesList for "estimate(..., estimationInit, ...)" seems not to be considered for model estimation
When adding opportunity lists to DyNAM network model, they seem not to be considered for model estimation, as results do not differ between models with and without opportunity lists.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
Effects should differ between a model that is estimating effects considering the entire network, and models that are constrained by opportunities limiting the network to only a subset of nodes.

Desktop (please complete the following information):

  • OS: macOS Catalina 10.15.7 (19H1519)
  • R Version 4.1.1 (2021-08-10) -- "Kick Things"
  • RStudio Version 2021.09.0 Build 351
  • Goldfish Version 1.5.1
marion-hoffman commented

Hi Hendrik,

Thanks for noticing this issue. Could you please give me the script or procedure you used to find this error?
I used this functionality recently and it still worked but maybe something got broken since then and I should go repair it.

Cheers
Marion

marion-hoffman commented

I have pushed a correction to the develop branch. I checked with DyNAM-i and it seems to do the trick, but you might want to test with your script (@hnunner or @auzaheta).
I hope it is solved :)

auzaheta commented

PR 1.6.2 includes 18add40 commit solving it.