Duplicate context entry for link-context and search-context
derickso opened this issue · 9 comments
Both link-context.css and search-context.css contain the same entry for
#context-searchselect, /* Search [Google] for "[selected]" */
which when enabled disables the 'Search [Google] for "[selected]" from both right click on selected text, and right click on links. There should be a way to toggle each one individually if they are contained within separate sheets
There are more of those.
From readme, "important notes":
Items that appear in different contexts with the same ID will disappear in all those contexts when activated only once. This is because many menus internally share the same very big context menu and are separated here for more convenience.
Sometimes there is a way to toggle them separately, but it is asked for so rarely that it's not worth bloating all the selectors and make it confusing.
Do you need to toggle it separately? Then I will have a look at it.
Yes, I would like to disable searching google on links but not on selected text. I'm not sure what the time constraints are to implementing this stuff but it didn't seem very involved, I would think it would be prudent to separate options whenever possible assuming it's possible. If there isn't sufficient time I could probably write a PR myself if pointed in the right direction
Try this:
#context-copylink[hidden="true"] ~ #context-searchselect
Did it work?
I tried adding it to link-context.css and it removed 'Search with Google' from a selection source but not link source (which is the opposite effect of what I'm looking for)
Attempting to flip the values did not work
Without looking into it again, what about #context-copylink[hidden="false"] ~ #context-searchselect ?
No effect
Ok had another look.
I was wrong because it contains double-negative logic and hidden attribute is not present when false. This one works:
#context-print-selection[hidden="true"] ~ #context-searchselect,
Yes it does, thanks