storj-archived/core

Callback already been called - Fail during large or high quantity file upload

Closed this issue · 1 comments

phutchins commented

Package Versions

/Users/philip/.nvm/versions/node/v6.9.1/lib
└── storj@4.0.1

Replace the values below using the output from node --version.

v6.9.1

Expected Behavior

I would expect an upload to succeed.

Actual Behavior

When uploading large files or large quantities of files, the probability of getting failures from farmers increases. When this is retried, it appears that the done callback is being passed along to the next try but it is already being called from the first failure.

Possibly here:
https://github.com/Storj/core/blob/master/lib/bridge-client/index.js#L642

Steps to Reproduce

  1. Upload a large file using the CLI
  2. Wait
  3. Look for 'callback has already been called' and the upload will crash and fail
tacticalchihuahua commented

Closing in favor of #656