Make sure CopyObject, CompleteMultipartUpload and moving objects respect the lock information

Question

Make sure CopyObject, CompleteMultipartUpload and moving objects respect the lock information

Closed this issue 2 months ago · 15 comments

Goal

This issue is to make meaningful progress on Object Lock implementation within core and edge services. Specifically, to support immutable backups in backup software products like Veeam.

What needs to be done? • Acceptance Criteria

Modify the corresponding to CopyObject, CompleteMultipartUpload and perhaps FinishMoveObject endpoints on the satellite to comply with the following:

make sure that it's not possible to mutate locked object versions using these endpoints

Summary

Implementation reference.

Depends on…

#400

Links

https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html
an easy-to-read and insightful introduction to Object Lock: Using S3 Object Lock

Answer 1 · 2024-07-16T17:15:29.000Z

Change satellite/metabase: adjust copying objects for Object Lock mentions this issue.

Answer 2 · 2024-07-16T18:35:17.000Z

Change pb: add retention to FinishCopyObjectRequest mentions this issue.

Answer 3 · 2024-07-16T19:49:56.000Z

Change satellite/metainfo: adjust CopyObject endpoints for Object Lock mentions this issue.

Answer 4 · 2024-07-18T12:10:03.000Z

Change pb: remove retention from BeginCopyObjectRequest mentions this issue.

Answer 5 · 2024-07-18T12:10:04.000Z

Change pb: add retention to FinishMoveObjectRequest mentions this issue.

Answer 6 · 2024-07-19T15:44:08.000Z

Change mod: bump storj.io/common mentions this issue.

Answer 7 · 2024-08-02T21:30:24.000Z

Change satellite/metabase: adjust moving objects for Object Lock mentions this issue.

Answer 8 · 2024-08-07T17:26:10.000Z

Change satellite/metabase: test moving with retention mentions this issue.

Answer 9 · 2024-08-07T17:26:11.000Z

Change satellite/metainfo: adjust FinishMoveObject endpoint for Object Lock mentions this issue.

Answer 10 · 2024-08-07T17:26:12.000Z

Change satellite/metabase: add more tests for moving locked objects mentions this issue.

Answer 11 · 2024-08-09T17:47:16.000Z

Change satellite/metainfo: add TestEndpoint_CopyObjectWithRetention mentions this issue.

Answer 12 · 2024-08-09T17:47:17.000Z

Change satellite/metabase: make FinishCopyObject's errors consistent mentions this issue.

Answer 13 · 2024-08-09T17:47:18.000Z

Change satellite/metabase: wrap Retention.Verifies in copy/move code mentions this issue.

Answer 14 · 2024-08-14T18:36:41.000Z

Change satellite/metainfo: add TestEndpoint_MoveObjectWithRetention mentions this issue.

Answer 15 · 2024-08-15T13:40:34.000Z

Change satellite/metainfo: add ErrObjectExpiration to ConvertMetabaseErr mentions this issue.