storybook-eol/addon-smart-knobs

It's necessary add both decorators?

renatorib opened this issue · 2 comments

Since withSmartKnobs encapsulates withKnobs here:
https://github.com/lucasconstantino/storybook-addon-smart-knobs/blob/master/src/index.js#L65

The usage of withKnobs decorator in readme example is unnecessary duplicate, right?

storiesOf('Button')
  .addDecorator(withSmartKnobs)
  .addDecorator(withKnobs) // <--------------- this
  .add('simple', () => <Button>Smart knobed button</Button>)
tko commented

Works for me without withKnobs (using globally added decorators.)

From #8 (npm v0.2.3) on you will need to add both decorators.
Sorry if this breaks your usage, just add decorator in manually and it should work. I forgot to tell the author that it can be a breaking change for some people.