Hardcoded start on 2020 for building historical data
Opened this issue · 1 comments
verovaleros commented
Describe the bug
When running AIP (development branch), it starts searching and attempting to find data from 2020:
DEBUG: PROCESSING DATE 2020-07-04
2023-07-26 14:59:15,647 - aip.data.access - DEBUG - Creating attacks for dates ['2020-07-04']
2023-07-26 14:59:15,647 - aip.data.access - DEBUG - Making dataset from raw data for dates ['2020-07-04']
2023-07-26 14:59:15,776 - root - DEBUG - Downloading data for 2020-07-04
To Reproduce
Steps to reproduce the behavior:
- Git clone:
git clone https://github.com/stratosphereips/AIP.git
- Docker build: 'docker build --build-arg uid=1000 --file etc/docker/Dockerfile --tag aip:latest .'
- Docker run:
docker run -ti -v /root/AIP/:/home/aip/AIP -v /opt/zeek/logs/:/home/aip/AIP/data/raw:ro -v /root/AIP/data/:/home/aip/AIP/data/:rw --name aip aip:latest bin/aip
- See error:
Looking at the code, it seems the starting date is hardcoded in the code:
Line 43 in a81a85b
AIP/lib/aip/models/prioritize.py
Line 113 in a81a85b
Expected behavior
The starting date should be read from the earliest date seen on honeypots_public_ips.csv
or from a parameter or variable.
verovaleros commented
The hardcoded date on models/prioritize.py is fixed in #23. Not closing the issue as the others remain to be fixed.