Possible conflict between prerequisites and instructions in the appendix
ryanmcfall opened this issue · 2 comments
What can we improve?
In the Prerequisites description on page 441, it is stated that one of the prerequisites is that You've created an SSL certificate within the AWS Certificate Manager for that domain and have the ANR for the SSL certificate).
Step 5 on page 444 says to run npm run certificate:deploy -- -profile stratospheric and that afterwards, you should copy the sslCertificateArn to the cdk.json file.
Both of these seem to indicate creation of an SSL certificate. It seems to me that the correct thing to do is to automate the creation of the certificate via the CDK, and so the prerequisite statement should be removed. Unless, perhaps, that's meant to only be done manually when the domain isn't hosted by Route53, in which case I think that needs to be clarified.
Can you clarify please?
Version
1.12 is the last revision listed in the change log, so I am assuming that is the version of the book.
Suggested Changes
No response
Hi @ryanmcfall good catch, thanks!
We need to revise this section as we had previously not automated the SSL certificate generation.
Anyways, you need to somehow create the SSL certificate within the AWS Certificate Manager (either manual or with our small construct)
Thanks, that's helpful information.