strawberry-graphql/strawberry

Broken documentation examples in page https://strawberry.rocks/docs/guides/dataloaders

Closed this issue · 6 comments

tejusp commented

Example within https://strawberry.rocks/docs/guides/dataloaders#usage-with-context is broken and can't be run due to invalid imports.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
tejusp commented

This issue can be closed after merging #3445

patrick91 commented

@tejusp what error do you get?

tejusp commented

image

Created another PR to fix it #3446

patrick91 commented

@tejusp what version of strawberry do you have? that error shouldn't be there anymore

tejusp commented

I'm using strawberry-graphql==0.219.2 (it's just 2 months old. Released: Feb 6, 2024)

How can we ensure the documentation is backwards compatible ?

patrick91 commented

@tejusp I think we need to add a version selector to the docs, but I'd prefer to do that after v1 😊

  • ❤️1