strimzi/strimzi.github.io

Logo doesn't load over https at https://strimzi.io

iranzo opened this issue · 9 comments

iranzo commented

I have:

  • Checked that the problem is not about the Strimzi documentation.
    Documentation issues (those with URLs starting https://strimzi.io/docs/...) should be reported here.
  • Included the URL of the page my issue is about
  • Described what I did see and what I was expecting to see

image

https://strimzi.io

scholzj commented

I don't seem to have this problem. Can you open the logo image it self? https://raw.githubusercontent.com/strimzi/strimzi-kafka-operator/master/documentation/logo/strimzi.png

It seems to be for whatever reason loaded from GitHub and not through the website. I think we should look into it and change it - maybe that is causing the issue.

iranzo commented

Hi,
No, chrome complains on privacy:

image

iranzo commented

I would say that logo should be copied to website repo and served from there locally

iranzo commented

Want me to PR it?

scholzj commented

That is interesting, because all my browsers seem to trust it. I wonder what TLS certificate is it presenting to you. Mine seems to be the regular GitHub Inc. certificate issues by DigiCert.

Anyway, I totally agree that it should be on the website it self. I will have a look into it.

iranzo commented

Seems to be 'plesk' one:

image

scholzj commented

That is weird. It looks like Plesk hijacks your connections to GitHub? I opened #111 for this - if you want toyu can double check that the logo works fine for you at https://deploy-preview-111--strimzi.netlify.com/

iranzo commented

image

Perfectly

scholzj commented

Ok, this should be now fixed. Thanks for raising this.