Unix domain socket support for statsd metrics
prudhvi opened this issue · 4 comments
Hi Team
Would you accept a PR to add support for UDS listening support for statsd metrics.
If so would you accept for listening metrics on DATAGRAM socket, I see that SSF span traces already support UDS via STREAM sockets.
But for statsd metrics thinking DATAGRAM is more suited to mimic UDP behavior and that the standard datadog clients support sending stats to DATAGRAM socket and we prefer the support for listening on datagram socket instead of stream socket for the same reason.
https://github.com/DataDog/datadog-agent/wiki/Unix-Domain-Sockets-support
https://github.com/DataDog/datadog-agent/wiki/Unix-Domain-Sockets-support#client-libraries-state
@asf-stripe any thoughts here?
Yep, I think that all seems very reasonable - the DATAGRAM type especially seems well-suited for representing the statsd packets (though I don't think I would be opposed to a STREAM socket implementation either). Given that there is precedent in the datadog agent, having your implementation stick to what dd-agent does sounds like the best path forward!
So, yep, very in favor - excited to see what you come up with!
Closing this as the PR is merged