strongloop/strong-globalize

String extraction

aastha93 opened this issue · 6 comments

aastha93 commented

slt-globalize -e skips string extraction from a file if it sees the method async get.

raymondfeng commented

strong-globalize uses https://github.com/estools/estraverse to parse the JavaScript source code. I wonder if estraverse is up to date with async/await syntax.

aastha93 commented

@raymondfeng The strong-globalize might need to update the dependency

raymondfeng commented

Unfortunately it already uses the latest version

Setogit commented

@aastha93: update to strong-globalize 3.1.0 or later or update to esprima 4.0.0 ?

raymondfeng commented

I assume that @aastha93 uses 3.2.0, which already depends on esprima": "^4.0.0", "estraverse": "^4.2.0". I'm afraid that estraverse@4.2.0 does not support async/await.

raymondfeng commented

I confirm that esprima": "^4.0.0" does support async/await.