Broken pc file in autotools build

Question

Broken pc file in autotools build

Closed this issue 2 years ago · 5 comments

Commit 388b614 produces a broken pc file in the autotools build, the variables are cmake specific and are not properly replaced.

Answer 1 · 2023-01-29T23:01:56.000Z

We encountered the same issue while updating libde265 in nixpkgs (NixOS/nixpkgs#213046). The pc file is broken when building with the autotools or with cmake. We ended up reverting 388b614 for the time being and continue to use the autotools build.

Answer 2 · 2023-01-30T08:22:20.000Z

Furthermore, this should be handled in a much better way for CMake anyway in order to support both relative and absolute paths in CMake variables. See https://github.com/strukturag/libheif/blob/54b16a7c151a78ee1a6600f0473ce0888129b5d7/CMakeLists.txt#L103-L114 for an approach that works for both Autotools and CMake, is relocatable, and supports NixOS absolute paths. @pkrause1980

Answer 3 · 2023-01-30T15:00:23.000Z

Please see also https://github.com/msys2/MINGW-packages/pull/15365/files#diff-3fdae71ac2fc6fc7cfca1eb5b4db49ced58ad93982d699c6fd804c6987e43b3b for other suggested .pc.in template changes.

Answer 4 · 2023-01-30T15:44:42.000Z

I have reverted 388b614 and copied over the same approach as used in libheif to fill-in the variables from CMake. Works again for me. Could you please check whether it also works for you?

Answer 5 · 2023-01-30T15:50:41.000Z

@farindk Can you please include the extra 2 lines from the MSYS2 patch please? There's no reason to substitute those.