strvcom/code-quality-tools

[commitlint-config] Inconsistency with company Git guidelines

ythecombinator opened this issue · 2 comments

The rules for this package extend config-conventional from commitlint authors. It turns out that our Git guidelines state that we should Capitalize the subject line. config-conventional, on the other hand, sets this as never.

The result is: if we follow our convention, having commitlint-config set, we get stuck in a commit-msg hook 🤷.

We should consider picking either on or the other.

My personal belief is that we should adopt conventional-commits.

This is being addressed in strvcom/strv-guidelines#2

This was addressed in this commit - you can now choose on a per-project basis to either follow conventional-commits or our own guidelines. 🎉 🍻

Thanks for the suggestion!