Dependencies

Question

Dependencies

Closed this issue 9 years ago · 2 comments

Is there a particular reason to include the karma modules as dependencies rather than devDependencies?

As far as I can tell they aren't required to use scrollMonitor with browserify when installing it with npm. Building each karma module is slow and actually fails on Node 0.12.0 so if they aren't required dependencies I think it would be preferable to move them to devDependencies.

Answer 1 · 2015-04-07T15:00:54.000Z

You're right, it shouldn't be that way. If you make a PR that fixes this I'll accept and npm publish.

Start with this branch if you can: https://github.com/sakabako/scrollMonitor/pull/33

Thanks

Answer 2 · 2015-06-04T20:52:55.000Z

Closing this as it's been merged.