styleguidist/mini-html-webpack-plugin

Regression after webpack 3 compat

vxna opened this issue · 3 comments

vxna commented

Noticed a destructive regression for webpack 4 after e00e1dd.

No js/css assets are emitted anymore, also no errors.
Can be reproduced with basic config, e.g. with no entry or ./src/index.js.

sapegin commented

I guess this check should be tweaked:

mini-html-webpack-plugin/index.js

Line 48 in 1f99098

if (Array.isArray(entrypoints)) {

Feel free to send a PR, if you have time.

sapegin commented

Should be fixed by c9df884.

vxna commented

Wasn't sure about the right fix in that case, so I decided to post an issue instead of PR.

I can confirm it's working now.

btw, Thanks for evolving the project, I'd try to maintain template to be in sync with upstream changes.