sualfred/script.embuary.helper

Blurring of embedded art is broken

Closed this issue · 6 comments

roidy commented

I made the following commit 0259ac1 to fix the issue with blurring not working on embedded artwork in mp3 files.

Since then the image functions have been reworked and blurring of embedded artwork in mp3 files is again broken :(

I think it's one of the following commits:-

d487846
or
f7adf3f

roidy commented

I've trace the issue to this line:-

image = url_unquote(image.replace('image://', ''))

Removing this entire line fixes the issue and allows embedded art to work again.

@roidy
Matrix or Leia?

could you also please add log(image, force=True) to the first line in this function so I can see how the path looks like on your end?

roidy commented

Leia.

Heres the log lines for mp3 embedded artwork, the first line is image at the function entry point and the second is after the unquote and replace..... This fails to get the image.

NOTICE: [ script.embuary.helper ] image://music@nfs%3a%2f%2f192.168.0.100%2fvolume1%2fMedia%2fMusic%2fAly%20%26%20AJ%2fDon%27t%20Go%20Changing%20-%20Single%2f01%20Don%27t%20Go%20Changing.mp3/

NOTICE: [ script.embuary.helper ] music@nfs://192.168.0.100/volume1/Media/Music/Aly & AJ/Don't Go Changing - Single/01 Don't Go Changing.mp3

However removing line 233 so image isn't unquoted and has the image:// part fixes the issue and embedded art loads fine.

@roidy
Unquoting is required to get valid cache filenames.

Can you confirm that this commit is fixing it?
5bb0baa

roidy commented

I can confirm that fixes the issue, thanks.