Pull Request Question, ES6 Rewrite
Opened this issue · 4 comments
this is a question more than an issue.
I forked this and rewrote it in ES6 and made it so there isn't a global dependancy on lodash (still uses lodash at moment but you don't need to include it globally). I also extracted the template to it's own file and export the service as part of the module
I use jspm to install it and I use gulp (instead of grunt) to build it.
I wasn't sure if you'd want such a massive change as a pull request so I figured I'd ask you and you can check it out and let me know.
Some of the pending pull requests already do all you're asking for. In fact the only thing missing is the es6 rewriting. We could unify both modules but keep es5 and es6 detached for now. What do you think?
I am not sure how you'd manage that kind of unification. If you have a plan for doing so I certainly have no problem with it.
I just published a new version, 0.3.0. I've defined a structure and a naming for factories. You can take a look at it and use the same structure and naming. Or if you think there's a better one just say so and I'll make the changes
I'll have to take some time this weekend to dig into your changes. Thanks for the heads up.