subquery/subql

[$600 in SQT] Improve ABI validation

stwiname opened this issue · 4 comments

stwiname commented

It is easy to make a typo or refer to an abi that doesn't exist. There should be some extra validation when building a project to ensure that they do exist. But having a datasource without an ABI provided should still be possible.

We should also increase validation that filters align with the provided ABIs.
A similar example of this can be found here https://github.com/subquery/network-app-backend/blob/main/scripts/checkFilters.ts

Other requirements

  • Documentation should be updated to include the feature
  • Changes should have test coverage of 80% on the relevant code changes
nnluukhtn commented

@jamesbayly @stwiname can I take this?

jamesbayly commented

Yes, you can, I will assign to you for two weeks

  • 👍1
jamesbayly commented

@nnluukhtn can you provide an update or an in progress PR?

nnluukhtn commented

Hi @jamesbayly , unfortunately I couldn't find the time to work on this yet last two weeks, sorry for the late update, can you remove me as assignee?