Ability to ask what is playing and who queued it
Opened this issue · 5 comments
I forked and added a feature to list "now playing" whenever a new track starts. https://github.com/Bookr/robut/tree/now-playing
It's not quite asking what's playing but that could be easily implemented. I figure that you have a room dedicated to the Rdio anyway, so this doesn't become to chatty.
Awesome. I just pulled this out to its own repo this weekend. I will try to incorporate these changes in that repo.
- Adam
On Nov 6, 2011, at 4:25 PM, Jeremy Wadsackreply@reply.github.com wrote:
I forked and added a feature to list "now playing" whenever a new track starts. https://github.com/Bookr/robut/tree/now-playing
It's not quite asking what's playing but that could be easily implemented. I figure that you have a room dedicated to the Rdio anyway, so this doesn't become to chatty.
Reply to this email directly or view it on GitHub:
#5 (comment)
They need to be wrapped in tests. :) I didn't start this TDD because (1) I had no idea how the code worked (which is not a fair excuse) and (2) the tests where already failing (which is also not an excuse). Ok, I didn't TDD it because it was Sunday. I can fork the robut-rdio project and submit a pull request there that includes test cases.
Cool. Also, maybe the next track ajax should be a POST not a GET?
On Mon, Nov 7, 2011 at 11:11 AM, Jeremy Wadsack <
reply@reply.github.com>wrote:
They need to be wrapped in tests. :) I didn't start this TDD because (1) I
had no idea how the code worked (which is not a fair excuse) and (2) the
tests where already failing (which is also not an excuse). Ok, I didn't TDD
it because it was Sunday. I can fork the robut-rdio project and submit a
pull request there that includes test cases.
Reply to this email directly or view it on GitHub:
#5 (comment)
Good feedback. That's was thinking about that. It doesn't precisely change the state so I thought GET made sense (and it was easier). Unless you think that writing a message to the chat stream counts as changing state.