sudo-project/sudo

plugins/sample is underlinked

mikhailnov opened this issue · 1 comments

plugins/sample is, first of all, built by default despite plugins/sample/README.
Also it fails to build with -Wl,--no-undefined

DEBUG: make[1]: Entering directory '/builddir/build/BUILD/sudo-1.9.12p2/plugins/sample'
DEBUG: /bin/sh ../../libtool --tag=disable-static --mode=link gcc -O2 -fomit-frame-pointer -gdwarf-4 -Wstrict-aliasing=2 -pipe -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -fstack-protector-strong --param=ssp-buffer-size=4 -fstack-protector-all -m64 -mtune=generic -Wl,-O2  -Wl,--no-undefined   -Wl,--enable-new-dtags -Wl,--allow-multiple-definition -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack  -Wc,-fstack-protector-strong -Wc,-fstack-clash-protection -Wc,-fcf-protection -Wl,--version-script,sample_plugin.map -o sample_plugin.la sample_plugin.lo ../../lib/util/libsudo_util.la -module -avoid-version -rpath /usr/lib64/sudo -shrext .so
DEBUG: libtool: link: gcc -shared  -fPIC -DPIC  .libs/sample_plugin.o   -Wl,-rpath -Wl,/builddir/build/BUILD/sudo-1.9.12p2/lib/util/.libs -Wl,-rpath -Wl,/usr/lib64/sudo ../../lib/util/.libs/libsudo_util.so -lcrypto -lpthread  -O2 -gdwarf-4 -fstack-protector-strong -fstack-protector-all -m64 -mtune=generic -Wl,-O2 -Wl,--no-undefined -Wl,--enable-new-dtags -Wl,--allow-multiple-definition -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-z -Wl,noexecstack -fstack-protector-strong -fstack-clash-protection -fcf-protection -Wl,--version-script -Wl,sample_plugin.map   -Wl,-soname -Wl,sample_plugin.so -o .libs/sample_plugin.so
DEBUG: make[1]: Leaving directory '/builddir/build/BUILD/sudo-1.9.12p2/plugins/sample'
DEBUG: /usr/bin/x86_64-rosa-linux-gnu-ld: .libs/sample_plugin.o: in function `policy_open':
DEBUG: /builddir/build/BUILD/sudo-1.9.12p2/plugins/sample/./sample_plugin.c:89: undefined reference to `sudo_printf'
DEBUG: /usr/bin/x86_64-rosa-linux-gnu-ld: .libs/sample_plugin.o: in function `io_open':
DEBUG: /builddir/build/BUILD/sudo-1.9.12p2/plugins/sample/./sample_plugin.c:404: undefined reference to `sudo_printf'

Thanks, this is fixed by 4f9da47.